[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PULL 00/21] Trivial patches for 2015-06-22

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PULL 00/21] Trivial patches for 2015-06-22
Date: Tue, 23 Jun 2015 20:08:33 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0

22.06.2015 19:02, Peter Maydell wrote:

> Fails to build on Windows:
> util/qemu-sockets.c: In function ‘inet_parse_connect_opts’:
> util/qemu-sockets.c:338: error: ‘AI_V4MAPPED’ undeclared (first use in this 
> function)

Hmm.  Does WIN really have no AI_V4MAPPED?  Does it have getaddrinfo
in the first place?  If yes, it should have AI_V4MAPPED too.

I added a conditional #define AI_V4MAPPED to 0 at the top of this
file, the same way AI_ADDRCONFIG is handled.

> (Also I had to resolve a conflict in configure, so if you rebase
> on current master you'll save me having to do it twice...)

Immediately before sending the pull request, I did a rebase and rebuild.
Apparently you pulled some other change before trying to pull this.
I usually rebase right before sending the request.  Just did the
rebase again, and fixed he conflict with guest-agent-msi change.

Will resend the pull request.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]