[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Check value for invalid nega

From: Gerd Hoffmann
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] Check value for invalid negative values
Date: Thu, 18 Jun 2015 12:18:43 +0200

On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote:
> For the same reason there is the v >= l test.
> The v >= l test state that the value can be out of range so it not always a 
> constant in the range.
> Adding the v < 0 check for every invalid value. As these are executed only 
> for logging should not be a performance penalty.
> I also hope the compiler is able to optimize
> if (v < 0 || v >= l)
> with 
> if ((unsigned) v >= l)

Just make v explicitly unsigned?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]