Re: [Qemu-trivial] [PATCH v2 1/7] hw/ppc/ppc440_bamboo.c: Add a member in MachineState to store irq array

[Shannon Zhao]

On 2015/6/4 22:12, Michael Tokarev wrote:
> 30.05.2015 10:54, Shannon Zhao wrote:
> > >From: Shannon Zhao<address@hidden>
> > >
> > >Here we add a member in MachineState to store the irq array returned
> > >from qemu_allocate_irqs. Then these irq arrays will be free before QEMU
> > >exit and it fixes the memory leak spotted by valgrind.
> Where the new member (machine->irqs) is being freed?

The machine->irqs will not be freed until the machine dies. Since 
machine init function only runs once and the allocated memories could be 
freed when QEMU exits.

> Can we add the
> generic machinery for it first, and next convert all places to it one
> by one?

--
Shannon