[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.
|
From: |
Peter Crosthwaite |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.h include |
|
Date: |
Tue, 26 May 2015 10:31:29 -0700 |
On Tue, May 26, 2015 at 10:18 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 26/05/2015 19:05, Peter Crosthwaite wrote:
>> OK, but it is an odd one out, would you be willing to accept
>> the double include that seems to be widespread?
>>
>> +#include "qemu_common.h"
>> #include "cpu.h"
>> -#include "exec/cpu-all.h"
>
> This is exactly what I meant. What is odd about it?
>
Nothing at all. It's just the other of the two valid resolutions to my
problem. I lost the coinflip when I wrote the patch :) Will respin
tonight.
Regards,
Peter
> In fact, including exec/cpu-all.h outside cpu.h is definitely odd.
>
> Paolo
>