[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE de
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] i440fx-test: guard ARRAY_SIZE definition with #ifndef |
|
Date: |
Thu, 30 Apr 2015 21:02:44 +0100 |
On 30 April 2015 at 20:28, Stefan Weil <address@hidden> wrote:
> Am 30.04.2015 um 21:16 schrieb Emilio G. Cota:
>>
>> ARRAY_SIZE is defined in osdep.h so having an unconditional
>> definition here is fragile.
FWIW, the original patch of this failed to build on x86 too,
so I don't think we currently include osdep.h from this file in
any circumstances... Where do you get the ARRAY_SIZE definition
from that presumably lets you build without this one?
> Why not include osdep.h via qemu-common.h and remove all other include
> statements which then are no longer needed? I'd prefer that variant.
Can we include qemu-common.h in these libqos standalone test
executables? I forget... The rtl8139 test seems to though, so
I guess it's OK.
-- PMM
- [Qemu-trivial] [PULL 34/42] coroutine: remove unnecessary parentheses in qemu_co_queue_empty, (continued)
- [Qemu-trivial] [PULL 34/42] coroutine: remove unnecessary parentheses in qemu_co_queue_empty, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 11/42] tpm: fix coding style, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 15/42] pci: Remove unused function ich9_d2pbr_init(), Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 22/42] libcacard: stop including qemu-common.h, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 36/42] i440fx-test: remove ARRAY_SIZE redefinition, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 21/42] docs/atomics.txt: fix two typos, Michael Tokarev, 2015/04/30
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/42] Trivial patches for 2015-04-30, Peter Maydell, 2015/04/30
[Qemu-trivial] [PULL 00/42] Trivial patches for 2015-04-30, Michael Tokarev, 2015/04/30