[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb()
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb() |
Date: |
Thu, 30 Apr 2015 08:08:54 +0300 |
From: Peter Crosthwaite <address@hidden>
No code uses the cpu_pc_from_tb() function. Delete from tricore and
arm which each provide an unused implementation. Update the comment
in tcg.h to reflect that this is obsoleted by synchronize_from_tb.
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
target-arm/cpu.h | 9 ---------
target-tricore/cpu.h | 5 -----
tcg/tcg.h | 6 ++++--
3 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 8df0b6a..d4a5899 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -1874,15 +1874,6 @@ static inline void cpu_get_tb_cpu_state(CPUARMState
*env, target_ulong *pc,
#include "exec/exec-all.h"
-static inline void cpu_pc_from_tb(CPUARMState *env, TranslationBlock *tb)
-{
- if (ARM_TBFLAG_AARCH64_STATE(tb->flags)) {
- env->pc = tb->pc;
- } else {
- env->regs[15] = tb->pc;
- }
-}
-
enum {
QEMU_PSCI_CONDUIT_DISABLED = 0,
QEMU_PSCI_CONDUIT_SMC = 1,
diff --git a/target-tricore/cpu.h b/target-tricore/cpu.h
index 90bf006..c14b5f9 100644
--- a/target-tricore/cpu.h
+++ b/target-tricore/cpu.h
@@ -395,9 +395,4 @@ int cpu_tricore_handle_mmu_fault(CPUState *cpu,
target_ulong address,
#include "exec/exec-all.h"
-static inline void cpu_pc_from_tb(CPUTriCoreState *env, TranslationBlock *tb)
-{
- env->PC = tb->pc;
-}
-
#endif /*__TRICORE_CPU_H__ */
diff --git a/tcg/tcg.h b/tcg/tcg.h
index add7f75..3d004ba 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -859,8 +859,10 @@ static inline size_t tcg_current_code_size(TCGContext *s)
* state is correctly synchronised and ready for execution of the next
* TB (and in particular the guest PC is the address to execute next).
* Otherwise, we gave up on execution of this TB before it started, and
- * the caller must fix up the CPU state by calling cpu_pc_from_tb()
- * with the next-TB pointer we return.
+ * the caller must fix up the CPU state by calling the CPU's
+ * synchronize_from_tb() method with the next-TB pointer we return (falling
+ * back to calling the CPU's set_pc method with tb->pb if no
+ * synchronize_from_tb() method exists).
*
* Note that TCG targets may use a different definition of tcg_qemu_tb_exec
* to this default (which just calls the prologue.code emitted by
--
2.1.4
- [Qemu-trivial] [PULL 18/42] util: Remove unused functions, (continued)
- [Qemu-trivial] [PULL 18/42] util: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 19/42] arm: cpu.h: Remove unused typdefs, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 38/42] target-mips: fix memory leak, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 40/42] kvm: Silence warning from valgrind, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 13/42] qemu-options: trivial spelling fix (messsage), Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 09/42] range: remove useless inclusions, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 01/42] tpm: Cast 64bit variables to int when used in DPRINTF, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 25/42] microblaze: mmu: Delete flip_um fn prototype, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 16/42] monitor: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 26/42] microblaze: cpu: Remote unused cpu_get_pc, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 41/42] tcg: Delete unused cpu_pc_from_tb(),
Michael Tokarev <=
- [Qemu-trivial] [PULL 42/42] microblaze: fix memory leak, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 17/42] usb: Remove unused functions, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 35/42] linux-user/elfload: use QTAILQ_FOREACH instead of open-coding it, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 31/42] cpus: use first_cpu macro instead of QTAILQ_FIRST(&cpus), Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 24/42] defconfigs: Piggyback microblazeel on microblaze, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 32/42] input: remove unused mouse_handlers list, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 39/42] vhost-user: remove superfluous '\n' around error_report(), Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 29/42] microblaze: cpu: Renumber EXCP_* constants to close gap, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 23/42] libcacard: do not use full paths for include files in the same dir, Michael Tokarev, 2015/04/30
- [Qemu-trivial] [PULL 28/42] microblaze: cpu: Delete EXCP_NMI, Michael Tokarev, 2015/04/30