qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH target-arm 2/2] arm: cpu.h: Delete unused cpu_pc_from_tb()
Date: Wed, 29 Apr 2015 08:43:59 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

27.04.2015 22:06, Peter Crosthwaite wrote:

> Does that mean a respin of this patch or should the tricore fix and
> the comment be a follow up?

Can you please resend whole thing in one change, removing single
unused function from two places and updating the comment, to fit
all the pieces together?  The whole thing is trivial enough to split
it up and the definition of "unused" in the subject will be true :)

I think that sometimes we make a bit "too trivial" patches which
aren't worth a patch by their own :) and the result is unnecessary
clutter in the git history.

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]