[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] Revised patch for QEMU Guest Agent compilaiton

From: Stefan Weil
Subject: Re: [Qemu-trivial] Revised patch for QEMU Guest Agent compilaiton
Date: Mon, 23 Mar 2015 20:43:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0

Am 23.03.2015 um 20:29 schrieb Joseph Hindin:

About a week ago I've submitted the revised patch for QEMU GA Windows cross-compilation. Since then I've not got any responses. Would you mind to look into the proposed patch?


       Joseph Hindin


Maybe you would have got a response if you had sent that patch to Paolo or me, too. Your patch has formal issues: it should have a short subject (< 80 characters typically) and some description. Your patch puts all text into the subject, so this becomes rather long. Please send an updated patch with "git send-email" and use scripts/checkpatch.pl
before you send it.

Is there any reason why you filter the -fstack-protector% the way you did in your patch
(and not as suggested by Paolo)?

Technically I think your patch fixes the problem.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]