[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v3] vl: fix resource leak with monitor_fdset_a

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd
Date: Thu, 19 Mar 2015 11:26:10 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0

15.03.2015 12:16, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd).  Free it.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>       v1->v2: line length [Fam], pass &error_abort [Shannon]
>         v2->v3: use "!!" instead of "? true : false" [Markus]

And ofcourse after finding v2 and v3, I applied this v3 one instead of
the initial version with a fixup.  Well, this boolean thing becomes
really ugly... :(



reply via email to

[Prev in Thread] Current Thread [Next in Thread]