[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] Fix typos in comments

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] Fix typos in comments
Date: Tue, 17 Mar 2015 09:24:57 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/17/2015 08:53 AM, Viswesh wrote:
> The commit message is changed per review comments of Peter Maydell.
> This should be good now.

These two sentences...

> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Viswesh <address@hidden>
> ---

...belong better here.  They describe how the patch changed from v1, and
not the patch itself (that is, a year from now when reading 'git log',
we won't care how many revisions it took to get to the patch that was
accepted, we will only care about the one revision that was accepted).

>  fsdev/virtfs-proxy-helper.c |  2 +-
>  target-tricore/translate.c  | 22 +++++++++++-----------
>  2 files changed, 12 insertions(+), 12 deletions(-)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]