[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/bt/sdp: Fix resource leak detect by coveri
Re: [Qemu-trivial] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity
Sun, 15 Mar 2015 13:23:54 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0
15.03.2015 12:21, Paolo Bonzini wrote:
> On 14/03/2015 11:07, Stefan Weil wrote:
>> This fixes the memory leak, but I still don't understand what is done here.
>> data is allocated, then filled with values, now it is also deallocated.
>> But I'm missing the part where all those data is used.
> "data" escapes in record->attribute_list[record->attributes].pair.
> The bug is in bt_l2cap_sdp_close_ch which does an invalid free every
> time it frees the first sdp->service_list[i].attribute_list->pair (but
> the qsort could have moved it elsewhere in the list). The right fix is
> to do a separate malloc for each attribute, instead of a single one.
Or, alternatively, to keep this `data' pointer in sdp to use it in
> In any case, it seems simpler to just leave this code aside.
How many times this code is called?
We have many many places in qemu where resources are allocated once
at startup and never freed just because there's no need to.