[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 1/7] backends: Fix warning from Sparse

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH 1/7] backends: Fix warning from Sparse
Date: Tue, 10 Mar 2015 09:41:10 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0

10.03.2015 09:22, Stefan Weil wrote:

> No, that was my mistake. Please excuse also the cris patch which I sent twice.
> I did not notice that it already had caused trouble, nor did I notice that I 
> had already sent it.
> In my local patch queue (~ 50 patches) there was even a 2nd cris patch
> which removed the unused variables...

No problems with that (except that we bothered Peter twice
with this cris thing already, and I really mean "we", since
it escaped my testing and accurate review too, and it was
twice too, so I'm as guilty if not more).

And this situation suggests that I should process and submit
patches a) more carefully and b) faster.  So it is, again,
good portion of my fault.  Not doing trivial-patches merging
for 3 weeks and rushing a whole lot in one go without that
good review isn't going to work well.

Thank you for the good work!  And it really is good, while


reply via email to

[Prev in Thread] Current Thread [Next in Thread]