[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rd
Dr. David Alan Gilbert
Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit
Wed, 4 Mar 2015 13:32:32 +0000
* Michael Tokarev (address@hidden) wrote:
> 04.03.2015 15:16, Dr. David Alan Gilbert wrote:
> > * Michael Tokarev (address@hidden) wrote:
> >> Do not check for rdma->host being empty twice. This removes a large
> >> "if" block, so code indentation is changed. While at it, remove an
> >> ugly goto from the loop, replacing it with a cleaner if logic. And
> >> finally, there's no need to initialize `ret' variable since is always
> >> has a value.
> >> Signed-off-by: Michael Tokarev <address@hidden>
> > Juan/Amit: There's a space at the end of a line that got in, so
> > that just needs fixing in the merge; it's after the 'break;'
> I already fixed it in my tree two days ago.
> > but the patch is a big improvement on what's there:
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > also tested on an RDMA system.
> Thank you!
> I think it's okay to merge it using the -trivial tree, I'm about to
> send a pull request today.
Yes, OK, although I'd generally prefer the RDMA stuff to go
through migration unless it's really trivial.
Dr. David Alan Gilbert / address@hidden / Manchester, UK