[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] migration/rdma: clean up qemu_rdma_dest_init
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit |
|
Date: |
Sat, 28 Feb 2015 12:26:41 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 |
19.02.2015 13:25, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (address@hidden) wrote:
>> Do not check for rdma->host being empty twice. This removes a large
>> "if" block, so code indentation is changed. While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logic. And
>> finally, there's no need to initialize `ret' variable since is always
>> has a value.
>
> This looks OK; have you got RDMA hardware to test with, if not I can
> give it a go.
No, I don't have any RDMA hw, I only compile-tested this code, and
double-checked the changes does not change behavour.
Thanks,
/mjt