[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 18/46] vl.c: fix memory leak spotted by valgrind
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 18/46] vl.c: fix memory leak spotted by valgrind |
Date: |
Tue, 10 Feb 2015 09:34:07 +0300 |
From: Christian Borntraeger <address@hidden>
valgrind complains about:
==42062== 16 bytes in 1 blocks are definitely lost in loss record 387 of 1,048
==42062== at 0x402DCB2: malloc (vg_replace_malloc.c:299)
==42062== by 0x40C1BE3: g_malloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x40DA133: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x40DB2E5: g_slist_prepend (in
/usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x801637FF: object_class_get_list_tramp (object.c:690)
==42062== by 0x40A96C9: g_hash_table_foreach (in
/usr/lib64/libglib-2.0.so.0.3800.2)
==42062== by 0x80164885: object_class_foreach (object.c:665)
==42062== by 0x80164975: object_class_get_list (object.c:698)
==42062== by 0x800100A5: machine_parse (vl.c:2447)
==42062== by 0x800100A5: main (vl.c:3756)
Lets free machines in case of mc.
Signed-off-by: Christian Borntraeger <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 2573afd..8c8f142 100644
--- a/vl.c
+++ b/vl.c
@@ -2452,6 +2452,7 @@ static gint machine_class_cmp(gconstpointer a,
gconstpointer b)
mc = find_machine(name);
}
if (mc) {
+ g_slist_free(machines);
return mc;
}
if (name && !is_help_option(name)) {
--
2.1.4
- [Qemu-trivial] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264, (continued)
- [Qemu-trivial] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 07/46] vl: Fix bogus error message for implied mon ID clashing, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 38/46] disas/sh4: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 29/46] QJSON: fix typo in author's email address, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 42/46] serial: Fix warnings caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 26/46] util/uri: uri_new() can't fail, drop dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 45/46] vga: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 11/46] linux-user/main.c: Use TARGET_SIG* instead of SIG*, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 25/46] usb: Pair g_malloc() with g_free(), not free(), Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 10/46] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 18/46] vl.c: fix memory leak spotted by valgrind,
Michael Tokarev <=
- [Qemu-trivial] [PULL 43/46] spice: Add missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 09/46] linux-user/syscall.c: lock_iovec: unlock vec[i] in failure processing code block, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 17/46] aes: remove a dead return statement, Michael Tokarev, 2015/02/10
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/46] Trivial patches for 2015-02-10, Peter Maydell, 2015/02/10
- [Qemu-trivial] [PULL 24/46] spapr_vio: Pair g_malloc() with g_free(), not free(), Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 03/46] Add tracing to xenfb., Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 32/46] rtl8139: g_malloc() can't fail, bury dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 19/46] qemu-sockets: Fix buffer overflow in inet_parse(), Michael Tokarev, 2015/02/10