[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH v3 0/5] Trivial patch about qemu-char
From: |
zhanghailiang |
Subject: |
[Qemu-trivial] [PATCH v3 0/5] Trivial patch about qemu-char |
Date: |
Tue, 4 Nov 2014 18:50:18 +0800 |
Patch 1 and 2 fix check about parameter in chr_parse_* functions.
Patch 3 fix wrong english state in error message in windows part of the code.
The last two patches convert some open functions to use Error API.
In patch 4, i have tried to convert some codes which will be used
in windows hypervisor. I didn't test them. But this is not too complex.
Markus has suggested add a separate patch for print_allowed_subtypes to use
error_prinf, but i think it's also in the context of "use Error API", so
i fix it togther in patch 5.
v3:
- discard wrong modify about qemu_chr_open_pty (Michael Tokarev)
- use !str[0] in place of strlen(str) == 0 which makes more sense for parameter
check (Michael Tokarev)
- Merge v2's patch 1 and 2 into a single patch (Michael Tokarev)
- Add new patch 3 to fix wrong english state in error message
- Use error_prinf instead of fprint for print_allowed_subtypes (Markus
Armbruster)
v2:
- don't use error_setg when followed by exit(), it does not report an error
(Eric Blake)
- check the parameter in qemu_chr_parse_* functions and remove the check in
qemu_chr_open_* functions. (Michael Tokarev)
Thanks very much for their reviews and suggestions;)
zhanghailiang (5):
qemu-char: fix parameter check in some qemu_chr_parse_* functions
spice-qemu-char: fix parameter checks in qemu_chr_parse_* functions
qemu-char: fix incorrect state in error message
qemu-char: convert some open functions to use Error API
spice-qemu-char: convert some functions to use Error API
include/ui/qemu-spice.h | 2 +-
qemu-char.c | 93 +++++++++++++++++++++++----------------------
spice-qemu-char.c | 26 ++++---------
stubs/qemu-chr-open-spice.c | 2 +-
4 files changed, 57 insertions(+), 66 deletions(-)
--
1.7.12.4