Re: [Qemu-trivial] [PATCH 3/4] pidfile: stop making pidfile error a special case

[Gonglei]

On 2014/10/31 16:02, Michael Tokarev wrote:

> 31.10.2014 10:58, Gonglei wrote:
>> On 2014/10/31 15:41, Michael Tokarev wrote:
> []
>>>>>>> +            exit(len == 1 && status == 0 ? 0 : 1);
>>>>>
>>>>> ...it is checked here, note the 'len == 1' part of the condition.
>>>>
>>>> If len != 1, the original code exit with 1, after your changes,
>>>> it will exit with 0. Right?
>>>
>>> with len != 1, the condition 'len == 1 && status == 0 ? 0 : 1'
>>
>> Ok. That's will be great if you can modify it
>> to "(len == 1 && status == 0 ) ? 0 : 1"
> 
> Well, ? operator has lowest precedence in C, && and || is higher,
> and == is even higher.  That's the basic rules of the language.
> So I don't really see why... ;)
> 
> The comment however should clear all confusion, hopefully.
> 

Hmm...

BTW, Do you receive mails subscribed form Qemu community?
Does the Qemu maillist system crash?
Since yesterday evening, my colleagues and I do not received mails.
It's too weird!

Thanks!
-Gonglei