[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] disas/arm: Remove redefinition o
Re: [Qemu-trivial] [Qemu-devel] [PATCH] disas/arm: Remove redefinition of ATTRIBUTE_UNUSED
Wed, 24 Sep 2014 02:09:42 -0700
On 24 September 2014 00:58, Michael Tokarev <address@hidden> wrote:
> 18.09.2014 21:25, Tobias Klauser wrote:
>> ATTRIBUTE_UNUSED is already defined in disas/bfd.h, which is included.
>> Thus, there is no need to redefine it.
> Is there any harm in keeping it here?
> While it really is a redifinition, I'm not sure what's the right thing
> here. This whole code is not from qemu, it is an external source imported,
> and that source is being maintained (but under different license as has
> already been discussed, so keeping changes at minimum might not be that
> good idea anymore). On the other hand this symbol is so common it should
> be defined in a common header. Yet on another hand, for these external
> sources wich has public API, it might not be a good idea to define it in
> a header to start with, because it might clash with project-local define,
> so it might be better to define it in either private header or in individual
So my take on the disas/ sources is:
* yes, they're from an external source
* but as you say, we're never going to take another drop from that
external source so we should feel free to make local bugfixes
and changes as we need to
* on the other hand, there's no point in making gratuitous changes
to them (they're never going to match the QEMU coding style,
So what's the rationale for this particular change? The duplication
is harmless, so why worry about it...