[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "
Re: [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"
Mon, 15 Sep 2014 15:29:35 +0200
On Mo, 2014-09-15 at 16:57 +0400, Michael Tokarev wrote:
> 15.09.2014 16:50, Michael Tokarev пишет:
> > 09.09.2014 15:19, john.liuli wrote:
> >> From: Li Liu <address@hidden>
> >> Eeay to reproduce, just try "qemu -monitor stdio -nographic"
> >> and type "quit", then the terminal will be crashed.
> >> There are two pathes try to call tcgetattr of stdio in vl.c:
> > This looks reasonable. Except of one thing -- how about renaming
> > stdio_is_ready to stdio_in_use? (I can do that when applying, no
> > need to resend anythnig). Because, well, stdio_is_ready is not
> > obvious at all, at least to me... :)
> And oh, the commit comment -- it is not 'terminal crash', it is
> 'terminal misbehavor' or something like that. Terminal does not
> crash, it just does not have proper settings after qemu exits.
For the record: The 'reset' utility does a full terminal reset and
restores sane settings. So usually you can recover from any terminal
f*ckup like this by first hitting Ctrl-C , then type "reset" ,
then hit Enter.
 To cancel anything which might be at your shell prompt.
 Possibly blindly in case echo happens to be turned off.