[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "
Re: [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"
Mon, 15 Sep 2014 16:57:15 +0400
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0
15.09.2014 16:50, Michael Tokarev пишет:
> 09.09.2014 15:19, john.liuli wrote:
>> From: Li Liu <address@hidden>
>> Eeay to reproduce, just try "qemu -monitor stdio -nographic"
>> and type "quit", then the terminal will be crashed.
>> There are two pathes try to call tcgetattr of stdio in vl.c:
> This looks reasonable. Except of one thing -- how about renaming
> stdio_is_ready to stdio_in_use? (I can do that when applying, no
> need to resend anythnig). Because, well, stdio_is_ready is not
> obvious at all, at least to me... :)
And oh, the commit comment -- it is not 'terminal crash', it is
'terminal misbehavor' or something like that. Terminal does not
crash, it just does not have proper settings after qemu exits.