[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v8] slirp/misc: Use the GLib memory allocation

From: zhanghailiang
Subject: Re: [Qemu-trivial] [PATCH v8] slirp/misc: Use the GLib memory allocation APIs
Date: Thu, 21 Aug 2014 08:42:51 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1

On 2014/8/20 23:03, Michael Tokarev wrote:
20.08.2014 18:57, Michael Tokarev пишет:
19.08.2014 12:30, zhanghailiang wrote:
Here we don't check the return value of malloc() which may fail.
Use the g_new() instead, which will abort the program when
there is not enough memory.

Also, use g_strdup instead of strdup and remove the unnecessary
strdup function.

I also will remove the HAVE_STRDUP define from slirp_config.h --
it is no longer needed there.

Applied to -trivial (with the above addition), thank you!

..And with removal of the corresponding #ifdef HAVE_STRDUP from slirp/misc.h.


OK! Thanks.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]