[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] block/vvfat.c: remove debugging

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] block/vvfat.c: remove debugging code to reinit stderr if NULL
Date: Tue, 19 Aug 2014 13:02:22 +0100

On 19 August 2014 12:58, Kevin Wolf <address@hidden> wrote:
> This specific patch isn't as trivial as it might look at the first
> sight (in other words: it's wrong). The part that you probably missed is
> that stderr isn't the real one when DEBUG is set:
>     #undef stderr
>     #define stderr STDERR
>     FILE* stderr = NULL;

Yikes. Can we rip that out as well, then?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]