[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v6 06/10] slirp/misc: Use g_malloc() instead o

From: zhanghailiang
Subject: Re: [Qemu-trivial] [PATCH v6 06/10] slirp/misc: Use g_malloc() instead of malloc()
Date: Mon, 18 Aug 2014 13:56:58 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1

On 2014/8/14 18:31, Michael S. Tsirkin wrote:
On Thu, Aug 14, 2014 at 03:29:17PM +0800, zhanghailiang wrote:
Here we don't check the return value of malloc() which may fail.
Use the g_malloc() instead, which will abort the program when
there is not enough memory.

Signed-off-by: zhanghailiang<address@hidden>
Reviewed-by: Alex Bennée<address@hidden>

OK, but then we need to find and replace free calls
as well.

Hmm, actually, i can't find any places that free the *ex_ptr and
the ptr allocated by strdup, so i think here, it does not need to call
g_free for them, may be they should be exist in all qemu's lifecycle,


  slirp/misc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/slirp/misc.c b/slirp/misc.c
index b8eb74c..f7fe497 100644
--- a/slirp/misc.c
+++ b/slirp/misc.c
@@ -54,7 +54,7 @@ int add_exec(struct ex_list **ex_ptr, int do_pty, char *exec,

        tmp_ptr = *ex_ptr;
-       *ex_ptr = (struct ex_list *)malloc(sizeof(struct ex_list));
+       *ex_ptr = (struct ex_list *)g_malloc(sizeof(struct ex_list));
        (*ex_ptr)->ex_fport = port;
        (*ex_ptr)->ex_addr = addr;
        (*ex_ptr)->ex_pty = do_pty;
@@ -235,7 +235,7 @@ strdup(str)
        char *bptr;

-       bptr = (char *)malloc(strlen(str)+1);
+       bptr = (char *)g_malloc(strlen(str)+1);
        strcpy(bptr, str);

        return bptr;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]