[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH v5 1/8] CODING_STYLE: Section about conditional st

From: arei.gonglei
Subject: [Qemu-trivial] [PATCH v5 1/8] CODING_STYLE: Section about conditional statement
Date: Mon, 11 Aug 2014 21:00:51 +0800

From: Gonglei <address@hidden>

Yoda conditions lack readability, and QEMU has a
strict compiler configuration for checking a common
mistake like "if (dev = NULL)". Make it a written rule.

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
 CODING_STYLE | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

index 4280945..d46cfa5 100644
@@ -91,3 +91,17 @@ Mixed declarations (interleaving statements and declarations 
within blocks)
 are not allowed; declarations should be at the beginning of blocks.  In other
 words, the code should not generate warnings if using GCC's
 -Wdeclaration-after-statement option.
+6. Conditional statements
+When comparing a variable for (in)equality with a constant, list the
+constant on the right, as in:
+if (a == 1) {
+    /* Reads like: "If a equals 1" */
+    do_something();
+Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
+Besides, good compilers already warn users when '==' is mis-typed as '=',
+even when the constant is on the right.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]