[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] hexdump: Add null guard o

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] hexdump: Add null guard on output file.
Date: Sun, 3 Aug 2014 14:11:49 +0100

On 3 August 2014 02:17, Peter Crosthwaite <address@hidden> wrote:
> Note that many of the existing call this with stderr as FP argument
> which in theory should be change to something that backs onto
> qemu_log. I suspect the file handle in this case will be NULL when
> logging is disabled and this patch avoid having to add all these
> conditionals.

For the qemu_log case we should handle the "don't log" condition
in the qemu_log() wrapper, especially since we probably want the
wrapper to take a log-mask anyway.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]