Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them

[Peter Crosthwaite]

On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster <address@hidden> wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> Otherwise, hot-unplug of pci-serial-2x trips the assertion
>> in memory_region_destroy:
>>
>>     (qemu) device_del gg
>>     (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021: 
>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first == ((void 
>> *)0))' failed.
>>     Aborted (core dumped)
>>
>> Reported-by: Markus Armbruster <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> Reviewed-by: Markus Armbruster <address@hidden>
>

Reviewed-by: Peter Crosthwaite <address@hidden>

> Would it make sense to add a "must not contain subregions" to
> memory_region_destroy()'s function comment?
>

Any reason to just not patch the memory region finaliser to unparent
all contained subregions automatically rather than assert? Destroying
a container should imply removing the subregion relationship and
simply orphan the subregion.

Regards,
Peter