[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PULL 21/23] bsd-user: replace fprintf(s

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()
Date: Sat, 31 May 2014 23:39:00 +0100

On 26 May 2014 08:20, Michael Tokarev <address@hidden> wrote:
> From: Le Tan <address@hidden>
> Replace fprintf(stderr,...) with error_report() in files bsd-user/*.
> The trailing "\n"s of the @fmt argument have been removed
> because @fmt of error_report() should not contain newline.
> Signed-off-by: Le Tan <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>

Was this patch tested? Building on FreeBSD the compiler
"warning: implicit declaration of function 'error_report' is invalid in C99"

because none of these bsd-user files include a header which
gives a prototype for error_report. Also, these are just
straightforward reporting of command line errors, and I
think that, like the linux-user code, we should handle
these in the obvious way by printing to stderr. There's no
need to drag in the error-handling framework for this,
especially since user-mode doesn't have the "maybe we
need to send this to the monitor" issues system emulation

In short, I think we need to revert this commit

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]