[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 04/23] util: Add 'static' attribute to function imp
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 04/23] util: Add 'static' attribute to function implementation |
Date: |
Thu, 27 Mar 2014 19:28:09 +0400 |
From: Stefan Weil <address@hidden>
The static code analyzer smatch complains because of a missing 'static'
attribute:
util/module.c:166:6: warning:
symbol 'module_load' was not declared. Should it be static?
'static' is used in the forward declaration, but not in the implementation.
Add it there, too.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
util/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/module.c b/util/module.c
index 863a8a3..214effb 100644
--- a/util/module.c
+++ b/util/module.c
@@ -163,7 +163,7 @@ out:
}
#endif
-void module_load(module_init_type type)
+static void module_load(module_init_type type)
{
#ifdef CONFIG_MODULES
char *fname = NULL;
--
1.7.10.4
- [Qemu-trivial] [PULL 10/23] target-i386: Avoid shifting left into sign bit, (continued)
- [Qemu-trivial] [PULL 10/23] target-i386: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 14/23] target-mips: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 09/23] CODING_STYLE: Section about mixed declarations, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 02/23] target-arm: Add missing 'static' attribute, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 04/23] util: Add 'static' attribute to function implementation,
Michael Tokarev <=
- [Qemu-trivial] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 19/23] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 03/23] hw/ide: Add missing 'static' attributes, Michael Tokarev, 2014/03/27
- [Qemu-trivial] [PULL 08/23] doc: update default PowerPC framebuffer settings, Michael Tokarev, 2014/03/27
- Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27, Peter Maydell, 2014/03/27