[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-trivial] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit |
|
Date: |
Mon, 10 Mar 2014 23:58:04 +0200 |
On Mon, Mar 10, 2014 at 07:10:39PM +0000, Peter Maydell wrote:
> Add U suffix to avoid undefined behaviour.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/pci/pci_host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
> index 77c7d1f..2c17916 100644
> --- a/hw/pci/pci_host.c
> +++ b/hw/pci/pci_host.c
> @@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
> {
> PCIHostState *s = opaque;
> uint32_t val;
> - if (!(s->config_reg & (1 << 31)))
> + if (!(s->config_reg & (1u << 31))) {
> return 0xffffffff;
> + }
> val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
> PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
> addr, len, val);
> --
> 1.9.0
>
- [Qemu-trivial] [PATCH 00/12] Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 06/12] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 08/12] hw/ppc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 05/12] target-mips: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 09/12] tests/libqos/pci-pc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 01/12] target-i386: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 10/12] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Peter Maydell, 2014/03/10
- [Qemu-trivial] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Peter Maydell, 2014/03/10