[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] libvixl: Fix format strings for
Re: [Qemu-trivial] [Qemu-devel] [PATCH] libvixl: Fix format strings for several int64_t values
Mon, 10 Mar 2014 14:20:55 +0000
On 7 March 2014 22:01, Andreas Färber <address@hidden> wrote:
> Am 07.03.2014 21:01, schrieb Stefan Weil:
>> Am 07.03.2014 20:42, schrieb Andreas Färber:
>>> Am 07.03.2014 20:15, schrieb Stefan Weil:
>>>> "%d" or "%x" won't work on hosts where int values are smaller than 64 bit.
>>>> Signed-off-by: Stefan Weil <address@hidden>
>>>> disas/libvixl/a64/disasm-a64.cc | 20 ++++++++++----------
>>>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>> Patch looks correct, but I see no indication that this is a backport
>>> from upstream libvixl. Have you submitted it there too?
>> If I knew how to submit it to libvixl, I'd have done that already. I did
>> not find any hint (e-mail address, keyword contrib) in the sources from
>> github. Can you help me?
> Google led me to the following:
This is the right email address and git repo, yes.
(our disas/libvixl/README gives the github URL, at least.)
I would encourage you to email them patches, it will
act as a prod for them to get themselves set up to
handle incoming contributions properly :-)
>> It would also be fine if someone just takes my
>> patch and applies it there.
> Hopefully Peter can help; I just remembered someone asking not to apply
> spelling fixes to not complicate functional backports.
I will apply this patch to target-arm.next. I'm happy
that we carry genuine bugfixes to libvixl (hopefully
in anticipation of them going away on a future update),
it's only non-functional changes I'd rather we don't
carry in our tree.