Re: [Qemu-trivial] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

[Kewei Yu]

2014/1/3 Paolo Bonzini <address@hidden>

Il 02/01/2014 15:45, Andreas Färber ha scritto:

>>> >>  v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c).
>> >
>> > What happens if qtest instead uses "-display none"?
> It does use that, since the commit I pointed to in v1. :)

And why do you need at all "-vnc none" if it also uses "-display none"?

Yeah, if "-display none", the vnc_display will be NULL in vl.c:4313, So the vnc is not initialized.

So, the "-vnc none" is excrescent.

Paolo

Kewei