[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: Fix compiler warning

From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)
Date: Mon, 30 Sep 2013 22:53:33 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0

Am 30.09.2013 11:59, schrieb Markus Armbruster:
> Stefan Weil <address@hidden> writes:
>> Am 29.09.2013 22:13, schrieb Michael Tokarev:
>>> 29.09.2013 19:41, Stefan Weil wrote:
>>>> The QEMU buildbot default_i386_debian_6_0 shows this warning:
>>>>    CC    migration.o
>>>> migration.c: In function 'qmp_query_migrate_capabilities':
>>>> migration.c:149: warning:
>>>>   'caps' may be used uninitialized in this function
>>> Gah, how disgusting.  The code is correct, yet gcc complains
>>> needlessly...
>> That's not the first time where we help the compiler by modifying the code.
> It's also not the first time where attempting to "help" the compiler
> made code less readable, or even less correct.  So let's be just as
> careful as with "real" changes.

Well, I try to do my best. ;-)

Is there anything wrong with my patch? I think the code looks cleaner
than before.

If there is a better way to fix the problem that's fine, too.

The problem withthe buildbot showing a compiler warning exists and we
should fix it somehow.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]