[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td
Date: Mon, 30 Sep 2013 00:15:53 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9

22.09.2013 00:26, Ján Veselý wrote:
Device communication errors need to be reported to driver.
Add a debug message while at it.

Signed-off-by: Jan Vesely <address@hidden>
  hw/usb/hcd-ohci.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 35f0878..0396e33 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1143,7 +1143,9 @@ static int ohci_service_td(OHCIState *ohci,
struct ohci_ed *ed)
              switch (ret) {
              case USB_RET_IOERROR:
              case USB_RET_NODEV:
+                DPRINTF("usb-ohci: got DEV ERROR\n");

why is this "DEV ERROR" ?  Note it is about 2 case statements, not one.

                  OHCI_SET_BM(td.flags, TD_CC, OHCI_CC_DEVICENOTRESPONDING);
+                break;
              case USB_RET_NAK:
                  DPRINTF("usb-ohci: got NAK\n");
                  return 1;

While the actual interesting change (adding break) looks
correct, and the whole thing is trivial indeed, this area
has a maintainer, -- Cc'ing Gerd for this.  If he's okay
I'll pick it up.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]