[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH] Quote extra_cflags in config-host.mak
Date: Wed, 11 Sep 2013 16:01:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 11/09/2013 15:41, Gabriel Kerneis ha scritto:
> The variable extra_cflags needs to be quoted in config-host.mak,
> in particular because it might contain parentheses that would
> otherwise be interpreted by the shell when reloading the file.
> For instance, if one wants to define some attribute with configure:
> ./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'"
> A more robust approach would be to escape every variable properly, but
> there is no portable equivalent to bash's "printf %q" solution. The
> current patch, while not bullet-proof, works well in the common case.
> Signed-off-by: Gabriel Kerneis <address@hidden>

Where does the shell read config-host.mak?  Make does not need the quotes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]