[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH trivial] main-loop: do not include slirp/slirp
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH trivial] main-loop: do not include slirp/slirp.h, use libslirp.h instead |
Date: |
Wed, 12 Jun 2013 08:50:16 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 12/06/2013 08:36, Michael Tokarev ha scritto:
>
> Including slirp/slirp.h is somewhat dangerous since it redefines
> errno on WIN32, so any file including it may misbehave wrt errno.
>
> Unfortunately libslirp isn't self-contained, it needs declaration
> of struct in_addr, which is provided by qemu/sockets.h. Maybe
> instead of #including qemu/sockets.h before libslirp.h, it is
> better to make the latter self-contained.
Yeah, but I agree with having the smallest patch for now.
Reviewed-by: Paolo Bonzini <address@hidden>