qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable


From: Ed Maste
Subject: Re: [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable
Date: Wed, 5 Jun 2013 16:11:47 -0400

On 5 June 2013 16:03, Michael Tokarev <address@hidden> wrote:
> 05.06.2013 19:02, Ed Maste wrote:
>> -  linker_script="-Wl,-T../config-host.ld 
>> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld"
>> +  linker_script="-Wl,-T../${config_host_ld} 
>> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld"
>
> Do we really care?  To me it looks like it is better
> to just remove the variable (which is nothing but just
> an extra indirection) and be done with it.

I don't really care one way or another, and am happy to expand the
other uses of it if that's preferred; it just seems odd to me to use
the variable in one spot and the literal filename in another.

(I found this while doing a little cleanup in preparation to avoid use
of the ldscripts/ files on FreeBSD.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]