[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h
Date: Wed, 30 Jan 2013 11:16:35 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Jan 21, 2013 at 12:03:47PM +0000, Peter Maydell wrote:
> Remove an unnecessary mutual inclusion loop between qemu-pixman.h and
> console.h, since the former was only including the latter for
> 'PixelFormat*', which can be provided by typedefs.h.  This requires a
> minor adjustment to the files which included qemu-pixman.h, since
> they were relying on it implicitly dragging in all of console.h.
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Stefan: I've made the obvious change to fix the spice compile issue,
> but none of my systems have a new enough spice-protocol/spice-server
> to allow me to configure with spice enabled. I'd appreciate it if
> you could check it does indeed compile OK now...
>  include/ui/qemu-pixman.h   |    2 +-
>  include/ui/spice-display.h |    1 +
>  ui/qemu-pixman.c           |    3 ++-
>  3 files changed, 4 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]