[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanu

From: Anthony Liguori
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups
Date: Mon, 28 Jan 2013 10:14:05 -0600
User-agent: Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)

Stefan Hajnoczi <address@hidden> writes:

> On Thu, Jan 24, 2013 at 05:04:29PM -0600, Jesse Larrew wrote:
>> Reformat the option parsing code in main() and various supporting functions
>> to conform to the QEMU coding style.
>> Signed-off-by: Jesse Larrew <address@hidden>
>> ---
>>  vl.c | 476 
>> +++++++++++++++++++++++++++++++++++++------------------------------
>>  1 file changed, 260 insertions(+), 216 deletions(-)
> Please CC address@hidden on trivial patches in the future.
> There has been discussion about whitespace cleanups recently and it also
> applies to this patch.  There is a cost to such patches - they require
> code review, can clog up the git-blame(1) output, and make it hard for
> stable branch or downstream maintainers to backport fixes.
> I'm happy to take this patch but I hope people don't get too
> trigger-happy because this isn't free.
> Waiting a while longer to merge in case Blue Swirl or anyone else wants
> to chime in.

Before the patch:

total: 75 errors, 125 warnings, 4230 lines checked

After the patch:

total: 59 errors, 67 warnings, 4274 lines checked

This feels like unnecessary churn to me.  If the patch was taking vl.c
to 0 errors, I'd be more inclined to pay the cost.  But I don't want
there to be 3-4 patches that break blame just to get a single file into


Anthony Liguori

> Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]