[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanu
Re: [Qemu-trivial] [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups
Mon, 28 Jan 2013 14:14:38 +0100
On Thu, Jan 24, 2013 at 05:04:29PM -0600, Jesse Larrew wrote:
> Reformat the option parsing code in main() and various supporting functions
> to conform to the QEMU coding style.
> Signed-off-by: Jesse Larrew <address@hidden>
> vl.c | 476
> 1 file changed, 260 insertions(+), 216 deletions(-)
Please CC address@hidden on trivial patches in the future.
There has been discussion about whitespace cleanups recently and it also
applies to this patch. There is a cost to such patches - they require
code review, can clog up the git-blame(1) output, and make it hard for
stable branch or downstream maintainers to backport fixes.
I'm happy to take this patch but I hope people don't get too
trigger-happy because this isn't free.
Waiting a while longer to merge in case Blue Swirl or anyone else wants
to chime in.
- Re: [Qemu-trivial] [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups,
Stefan Hajnoczi <=