[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Create proper size file f

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Create proper size file for disk mirror
Date: Fri, 25 Jan 2013 11:13:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 01/25/2013 11:10 AM, Vishvananda Ishaya wrote:
> On Jan 25, 2013, at 1:18 AM, Kevin Wolf <address@hidden> wrote:
>> Am 24.01.2013 19:00, schrieb Vishvananda Ishaya:
>>> The qmp monitor command to mirror a disk was passing -1 for size
>>> along with the disk's backing file. This size of the resulting disk
>>> is the size of the backing file, which is incorrect if the disk
>>> has been resized. Therefore we should always pass in the size of
>>> the current disk.
>>> Signed-off-by: Vishvananda Ishaya <address@hidden>
>> Thanks, applied to the block branch.
>> Can you send a qemu-iotests test case that tests this condition?
>> (Probably best as an extension to case 041)
> I have a test for this. Would you like it as a separate patch or
> should i respin the original?

Since the original has already been applied to the block branch, you are
best off sending a separate patch for the test addition.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]