[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tra

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema
Date: Fri, 25 Jan 2013 16:49:31 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 01/25/2013 07:07 AM, Michal Privoznik wrote:
>> On 25.01.2013 14:55, Markus Armbruster wrote:
>>> Michal Privoznik <address@hidden> writes:
>>>> Currently, we are using 'tray_open' in QMP and 'tray-open' in
>>>> HMP. However, the QMP documentation was mistakenly using the
>>>> HMP version.
>>> Could you point me to where we're using "tray_open"?
>> qemu.git $ git grep -npC8 tray_open qapi-schema.json
>> qapi-schema.json-705-{ 'type': 'BlockInfo',
>> qapi-schema.json-706- 'data': {'device': 'str', 'type': 'str',
>> removable': 'bool',
>> qapi-schema.json-707- 'locked': 'bool', '*inserted':
>> BlockDeviceInfo',
>> qapi-schema.json:708: '*tray_open': 'bool', '*io-status':
>> BlockDeviceIoStatus',
>> qapi-schema.json-709-           '*dirty': 'BlockDirtyInfo' } }
> And since existing qemu versions output tray_open, we would be breaking
> API if we fixed the QMP to return tray-open (libvirt could cope with
> that API break by checking both spellings, but that feels dirty).

Breaking the API is out of the question.

We suck at consistency :(

reply via email to

[Prev in Thread] Current Thread [Next in Thread]