[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual incl
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h
Fri, 18 Jan 2013 13:52:37 +0000
On 18 January 2013 13:47, Stefan Hajnoczi <address@hidden> wrote:
> On Thu, Jan 17, 2013 at 03:52:08PM +0000, Peter Maydell wrote:
>> Remove an unnecessary mutual inclusion loop between qemu-pixman.h and
>> console.h, since the former was only including the latter for
>> 'PixelFormat*', which can be provided by typedefs.h. This requires a
>> minor adjustment to qemu-pixman.c, which was relying on the implicit
>> inclusion of console.h for the actual struct PixelFormat definition,
>> and on implicitly dragging in a header defining NULL.
> CC ui/curses.o
> In file included from ui/spice-core.c:40:0:
> /home/stefanha/qemu/include/ui/spice-display.h:93:5: error: unknown type name
Oops. I don't have spice in my dev environment I guess.
Having spice-display.h include console.h will probably fix this.