[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] pseries: Remove unneeded include
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) |
|
Date: |
Thu, 3 Jan 2013 20:58:30 +1100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 03, 2013 at 09:59:46AM +0100, Stefan Hajnoczi wrote:
> On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote:
> > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
> > so remove it.
> >
> > Signed-off-by: Stefan Weil <address@hidden>
> > ---
> > hw/spapr_nvram.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I audited the code and cannot see anything that would require
> <sys/mman.h>.
Oh, yes, that would have been from an early draft that directly
mmap()ed a backing file rather than using the block layer. It
shouldn't be needed any more.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: Digital signature