Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

[Johnson, Eric]

Hi Chen,

Sorry I must have made a copy paste error.  I access the documents internally. 
I'll double check the link tomorrow.

The document I referenced is the MIPS64 not the microMIPS64.

Do not change the names. The LD32 and SD32 are microMIPS specific. The 
assembler LD and SD opcodes work for either MIPS64 or microMIPS64.

Eric

On Nov 14, 2012, at 7:27 PM, "陳韋任 (Wei-Ren Chen)" <address@hidden> wrote:

> On Thu, Nov 15, 2012 at 02:34:31AM +0000, Johnson, Eric wrote:
>> Hi Chen,
>> 
>> Please only remove the POOL48A opcode.
>> 
>> The others are documented in the microMIPS64 Instruction Set manual ( 
>> http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf
>>  ).  See http://www.mips.com/products/architectures/mips64/ for other 
>> relavent docs.
>> 
>> Instead of removing them please surround the POOL32S, DADDIU32, SD32, and 
>> LD32 opcodes with
>> #if defined(TARGET_MIPS64)
> 
>  Just want to make sure I am reading the right manual, are you refering
> to [1] or [2]? The link you gave me is about MIPS64 not microMIPS64, I 
> am not sure which one I should look into. I can find DADDIU, SD, and LD
> in [1] and [2], all *without* 32 suffix. Should I change their name?
> I cannot find POOL32S in both document, would you like to point it out?
> Thanks.
> 
> Regards,
> chenwj
> 
> [1] MIPS Architecture For Programmers
>      Volume I-B: Introduction to the microMIPS64 Architecture
> 
>    MD00743-2B-microMIPS64INT-AFP-03.02.pdf
> 
> [2] MIPS Architecture For Programmers
>      Volume II-A: The MIPS64 Instruction Set
> 
>    MD00087-2B-MIPS64BIS-AFP-03.51.pdf
> 
> -- 
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj