[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] vnc: fix "info vnc" with "-vnc ..., reverse=o
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] vnc: fix "info vnc" with "-vnc ..., reverse=on" |
Date: |
Fri, 12 Oct 2012 10:55:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 10, 2012 at 02:30:58PM +0200, Paolo Bonzini wrote:
> When reverse connection is in use, there is no active VNC server
> socket. Because of this, getsockopt(-1, ...) is attempted and
> the following error is emitted:
>
> $ socat TCP-LISTEN:5900,reuseaddr TCP-LISTEN:5901,reuseaddr &
> $ x86_64-softmmu/qemu-system-x86_64 -vnc localhost:5900,reverse -monitor
> stdio
> QEMU 1.2.50 monitor - type 'help' for more information
> (qemu) info vnc
> An undefined error has occurred
>
> Because however the host, family, service and auth fields are
> optional, we can just exit if there is no active server socket.
>
> $ x86_64-softmmu/qemu-system-x86_64 -vnc localhost:5900,reverse -monitor
> stdio
> QEMU 1.2.50 monitor - type 'help' for more information
> (qemu) info vnc
> Server:
> Client:
> address: 127.0.0.1:5900
> x509_dname: none
> username: none
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> ui/vnc.c | 4 ++++
> 1 file modificato, 4 inserzioni(+)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan