[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity |
Date: |
Wed, 19 Sep 2012 18:41:14 +0200 |
hw/pflash_cfi01.c:209:
check_return: Calling function "bdrv_write" without checking return value (as
is done elsewhere 35 out of 37 times).
hw/pflash_cfi02.c:144:
unterminated_default: The default case is not terminated by a 'break' statement.
hw/pflash_cfi02.c:238:
check_return: Calling function "bdrv_write" without checking return value (as
is done elsewhere 35 out of 37 times).
Signed-off-by: Stefan Weil <address@hidden>
---
hw/pflash_cfi01.c | 6 ++++--
hw/pflash_cfi02.c | 7 +++++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 56ed33f..27ae4aa 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -205,8 +205,10 @@ static void pflash_update(pflash_t *pfl, int offset,
/* round to sectors */
offset = offset >> 9;
offset_end = (offset_end + 511) >> 9;
- bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9),
- offset_end - offset);
+ if (bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9),
+ offset_end - offset) == -1) {
+ fprintf(stderr, "pflash: Error writing to flash storage\n");
+ }
}
}
diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
index 3e2002e..bca7d1b 100644
--- a/hw/pflash_cfi02.c
+++ b/hw/pflash_cfi02.c
@@ -147,6 +147,7 @@ static uint32_t pflash_read (pflash_t *pfl,
target_phys_addr_t offset,
DPRINTF("%s: unknown command state: %x\n", __func__, pfl->cmd);
pfl->wcycle = 0;
pfl->cmd = 0;
+ /* Fall through */
case 0x80:
/* We accept reads during second unlock sequence... */
case 0x00:
@@ -236,8 +237,10 @@ static void pflash_update(pflash_t *pfl, int offset,
/* round to sectors */
offset = offset >> 9;
offset_end = (offset_end + 511) >> 9;
- bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9),
- offset_end - offset);
+ if (bdrv_write(pfl->bs, offset, pfl->storage + (offset << 9),
+ offset_end - offset) == -1) {
+ fprintf(stderr, "pflash: Error writing to flash storage\n");
+ }
}
}
--
1.7.10
- [Qemu-trivial] [PATCH] pflash: Avoid warnings from coverity,
Stefan Weil <=