[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] ivshmem, qdev-monitor: fix order of qerror pa
Re: [Qemu-trivial] [PATCH] ivshmem, qdev-monitor: fix order of qerror parameters
Tue, 14 Aug 2012 11:43:03 -0300
On Tue, 14 Aug 2012 16:15:37 +0200
Alberto Garcia <address@hidden> wrote:
> On Tue, Aug 14, 2012 at 10:42:30AM -0300, Luiz Capitulino wrote:
> > Additionally, we should check all old QERR_ macros to see if anyone
> > else swaps parameters like this and change them too.
> Yes, I also noticed the problem and checked all QERR_ macros, I only
> found the two that I corrected in the patch, but double checking the
> list won't hurt I guess :)
Yes, you're right. I've just double checked it and these are the only
two cases and both have only one single user.
This patch is fine then:
Reviewed-by: Luiz Capitulino <address@hidden>