[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] exec.c: Remove out of date comment

From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] exec.c: Remove out of date comment
Date: Wed, 1 Aug 2012 15:17:00 +0100

On 1 August 2012 15:05, Avi Kivity <address@hidden> wrote:
> On 08/01/2012 04:35 PM, Peter Maydell wrote:
>> Remove an out of date comment: this comment used to be attached to
>> cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally
>> inserted a couple of other functions between the comment and its function.
>> It is in any case obsolete since (a) the function arguments it refers
>> to have been replaced with a single MemoryRegionSection* argument and
>> (b) the inability to handle regions whose offset_within_address_space
>> and offset_within_region aren't equally aligned was fixed as part of
>> the rewrite of this code.
> (c) it doesn't use the conventional block comment style.

I agree that I don't like the aesthetics of this style of comment
but we don't actually mandate a One True Comment Format in HACKING
so I usually try to suppress my preferences in code review :-)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]