Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment

[Blue Swirl]

On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil <address@hidden> wrote:
> Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code,
> but left the related comment at a location where it no longer
> belongs to.
>
> The patch moves the comment to the correct callback and improves the text.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  hw/qdev.h |   11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/hw/qdev.h b/hw/qdev.h
> index 247dd1e..a2cbd9d 100644
> --- a/hw/qdev.h
> +++ b/hw/qdev.h
> @@ -78,12 +78,6 @@ struct DeviceState {
>      int alias_required_for_version;
>  };
>
> -/*
> - * This callback is used to create Open Firmware device path in accordance 
> with
> - * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus 
> bindings
> - * can be found here http://playground.sun.com/1275/bindings/.
> - */
> -
>  #define TYPE_BUS "bus"
>  #define BUS(obj) OBJECT_CHECK(BusState, (obj), TYPE_BUS)
>  #define BUS_CLASS(klass) OBJECT_CLASS_CHECK(BusClass, (klass), TYPE_BUS)
> @@ -95,6 +89,11 @@ struct BusClass {
>      /* FIXME first arg should be BusState */
>      void (*print_dev)(Monitor *mon, DeviceState *dev, int indent);
>      char *(*get_dev_path)(DeviceState *dev);
> +    /*
> +     * This callback is used to create Open Firmware device path in 
> accordance
> +     * with OF spec http://forthworks.com/standards/of1275.pdf. Individual 
> bus
> +     * bindings can be found at http://playground.sun.com/1275/bindings/.
> +     */

The links are dead. Since you are improving the text, maybe you could
find archived versions.

>      char *(*get_fw_dev_path)(DeviceState *dev);
>      int (*reset)(BusState *bus);
>  };
> --
> 1.7.10
>
>