[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] configure: Fix creation of sy

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] configure: Fix creation of symbolic links for MinGW toolchain
Date: Wed, 25 Apr 2012 09:39:39 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Mar 19, 2012 at 01:20:47PM +0100, Stefan Weil wrote:
> The MinGW toolchain on w32/w64 hosts does not create symbolic links,
> but implements 'ln -s' similar to 'cp -r'.
> In incremental out of tree builds, this resulted in files which
> were not updated when their counterparts in the QEMU source tree
> changed. Especially for Makefile* this happened very often.
> With this patch, the 'symlinked' files are now always updated for
> out of tree builds. Similar code was already used for the symbolic
> link of libcacard/Makefile.
> The symlink macro always removes the target before it is created
> again, therefore the rm command for libcacard/Makefile was redundant
> and is removed now.
> Macro symlink is also used with directories. To remove them on w32
> hosts, a recursive rm is needed.
> v2:
> Quote arguments in shell function symlink, and also quote any argument
> which is passed to symlink and which contains macros. This should reduce
> the chance of accidents caused by rm -rf.
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  configure |   21 ++++++++++-----------
>  1 files changed, 10 insertions(+), 11 deletions(-)

Sorry, this got lost in my inbox.  If you send patch revisions as
top-level emails then it's easier to notice them.  I probably marked it
as read and forgot about it because being part of the original email
thread made it appear like the discussion was still continuing.

Thanks, applied to the trivial patches tree:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]